fix: update TypeScript schema generator to use source/ directory#161
Open
misza-one wants to merge 1 commit intoUniversal-Commerce-Protocol:mainfrom
Open
fix: update TypeScript schema generator to use source/ directory#161misza-one wants to merge 1 commit intoUniversal-Commerce-Protocol:mainfrom
misza-one wants to merge 1 commit intoUniversal-Commerce-Protocol:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
The generate_ts_schema_types.js script still referenced the removed spec/ directory. Updated to use source/ which is where schemas now live after the migration in Universal-Commerce-Protocol#125. Fixes Universal-Commerce-Protocol#150
misza-one
force-pushed
the
fix/ucp-150-ts-schema-path
branch
from
a47bdaa to
d4af096
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates
generate_ts_schema_types.jsto referencesource/instead of the removedspec/directory. Thespec/directory was removed in #125, but this script was not updated — running it currently finds 0 schemas.Single line change on line 5:
Fixes #150
Type of change
Checklist